Changing job on security while exploring causes crash #48

Closed
opened 2016-03-03 19:59:15 +00:00 by tobias- · 4 comments
tobias- commented 2016-03-03 19:59:15 +00:00 (Migrated from gitlab.com)

Worker is currently exploring a docker raider vessel. Changing job on "Vega Barker" from Security to Doctor crashes the game with the following stack. Attached save game causing the crash

SpacebaseDF9AutoSave.sav

Data/Scripts/Utility/EmergencyBeacon.lua:388: attempt to index a nil value
stack traceback:
	Data/Scripts/Utility/EmergencyBeacon.lua in function '_testChar'
	Data/Scripts/Utility/EmergencyBeacon.lua:458 in function 'charAbandoned'
	Data/Scripts/Utility/Tasks/Explore.lua:101 in function 'onComplete'
	Data/Scripts/Utility/Task.lua:292 in function 'interrupt'
	Data/Scripts/Utility/Tasks/Explore.lua:152 in function 'onUpdate'
	Data/Scripts/Utility/Task.lua:265 in function 'update'
	Data/Scripts/Character.lua:2452 in function 'updateAI'
	Data/Scripts/CharacterManager.lua:419 in function 'onTick'
	Data/Scripts/GameRules.lua:399 in function 'onTick'
	Data/Scripts/main.lua:232 in function <Data/Scripts/main.lua:220>
Segmentation fault
Worker is currently exploring a docker raider vessel. Changing job on "Vega Barker" from Security to Doctor crashes the game with the following stack. Attached save game causing the crash [SpacebaseDF9AutoSave.sav](/uploads/9692e72f4e7a593821a79c4978edb2c7/SpacebaseDF9AutoSave.sav) ``` Data/Scripts/Utility/EmergencyBeacon.lua:388: attempt to index a nil value stack traceback: Data/Scripts/Utility/EmergencyBeacon.lua in function '_testChar' Data/Scripts/Utility/EmergencyBeacon.lua:458 in function 'charAbandoned' Data/Scripts/Utility/Tasks/Explore.lua:101 in function 'onComplete' Data/Scripts/Utility/Task.lua:292 in function 'interrupt' Data/Scripts/Utility/Tasks/Explore.lua:152 in function 'onUpdate' Data/Scripts/Utility/Task.lua:265 in function 'update' Data/Scripts/Character.lua:2452 in function 'updateAI' Data/Scripts/CharacterManager.lua:419 in function 'onTick' Data/Scripts/GameRules.lua:399 in function 'onTick' Data/Scripts/main.lua:232 in function <Data/Scripts/main.lua:220> Segmentation fault ```
tobias- commented 2016-03-03 20:05:00 +00:00 (Migrated from gitlab.com)

Correction. Seems to be related to beacon more than exploring. I loaded the game and set a beacon for the team and then everything worked as expected. Can be related or identical to #47

Correction. Seems to be related to beacon more than exploring. I loaded the game and set a beacon for the team and then everything worked as expected. Can be related or identical to #47
danielrbrose commented 2016-03-13 10:52:18 +00:00 (Migrated from gitlab.com)

EDIT came across this again, so was more scientific

I found that same character ("chris adana") caused this bug when removed from security whilst a beacon was active, but not if no beacon

I also recall that removing trouble player from squad whilst beacon did cause this crash once.

I also have suspicion that when i removed beacon in past i left no time gap and they were still doing security task when i changed role, causing bug.

I let them do thier job, removed marker, hit play long enough for them to start heading to homebase, then removed from team, let a few seconds pass, then removed from role.

No crash

Tell me if you need savefile, but i think you can mimic this yourself easily enough.




original post


I do not have an autosave sorry, but i can corroborate with empirical evidence that this occurred on at least 2 playthroughs.

Though i did try clearing the marker (which was already set before autosave) before clearing roles, no effect i thought but i did heavily focus on that aspect, so it could well be that.

But here is what i have seen, though not thoroughly tested (as i just killed off or remembered who not to assign):

You change a role from security to anything else on a certain character, immediate crash.

First playthrough i ended up giving up after this repeated on loading autosave, unsure of exact conditions.

Second playthrough i took more note, and found that:

  • it doesnt 'appear' to be avoidable by clearing security marker before role change ('appears' means loosly tested, no obvious effect)
  • it doesnt 'appear' to be affected by removing said member from security squad before role change
  • it doesnt even 'appear' to be related to a specific security matter, as that same character when added then removed from security in a later incident caused same crash
  • multiple characters can cause this, at least 2 of a 15+ roster
  • untested whether toggling just this character on/off security role (so no other security members) would cause crash, but it does 'appear' to crash regardless of whether first or last member to be role reverted
<br/> **EDIT** came across this again, so was more scientific I found that same character ("chris adana") caused this bug when removed from security whilst a beacon was active, but not if no beacon I also recall that removing trouble player from squad whilst beacon did cause this crash once. I also have suspicion that when i removed beacon in past i left no time gap and they were still doing security task when i changed role, causing bug. I let them do thier job, removed marker, hit play long enough for them to start heading to homebase, then removed from team, let a few seconds pass, then removed from role. No crash Tell me if you need savefile, but i think you can mimic this yourself easily enough. <br/> --- <br/> *original post* <br/> I do not have an autosave sorry, but i can corroborate with empirical evidence that this occurred on at least 2 playthroughs. Though i did try clearing the marker (which was already set before autosave) before clearing roles, no effect i thought but i did heavily focus on that aspect, so it could well be that. But here is what i have seen, though not thoroughly tested (as i just killed off or remembered who not to assign): You change a role from security to anything else on a certain character, immediate crash. First playthrough i ended up giving up after this repeated on loading autosave, unsure of exact conditions. Second playthrough i took more note, and found that: - it doesnt 'appear' to be avoidable by clearing security marker before role change ('appears' means loosly tested, no obvious effect) - it doesnt 'appear' to be affected by removing said member from security squad before role change - it doesnt even 'appear' to be related to a specific security matter, as that same character when added then removed from security in a later incident caused same crash - multiple characters can cause this, at least 2 of a 15+ roster - untested whether toggling just this character on/off security role (so no other security members) would cause crash, but it does 'appear' to crash regardless of whether first or last member to be role reverted
bryceharrington commented 2016-03-19 10:22:30 +00:00 (Migrated from gitlab.com)

Thanks for reporting this issue.

This looks much like one of the crashes fixed in 1.08.1. Please re-test against that release. If for some reason that doesn't fix the crash, please reopen and we'll take another look.

Thanks for reporting this issue. This looks much like one of the crashes fixed in 1.08.1. Please re-test against that release. If for some reason that doesn't fix the crash, please reopen and we'll take another look.
bryceharrington commented 2016-03-19 10:22:30 +00:00 (Migrated from gitlab.com)

Status changed to closed

Status changed to closed
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ald_productions/spacebase-v2-updated-code#48
No description provided.