ald_productions/spacebase-v2-updated-code
1
0
Fork 0
Code Issues 29 Pull requests Projects 4 Releases 1 Packages Wiki Activity Actions

Fix Issue #16: Remove obsolete _prerollRaiders check in ImmigrationEvent #56

Merged
HLaan merged 1 commit from master into master 2016-01-26 19:01:28 +00:00
Conversation 4 Commits 1 Files changed 1 +1 -1
HLaan commented 2016-01-23 20:02:15 +00:00 (Migrated from gitlab.com)
Copy link

An obsolete check was placed in ImmigrationEvent that caused
CompoundEvent to shit its proverbial pants when processing
HostileImmigrationEvents because this check prevented tCharSpawnStats to
get added to the Event. This _prerollRaiders check was deemed obsolete
because this was the only place (left) in the code that mentioned this
variable.

An obsolete check was placed in ImmigrationEvent that caused CompoundEvent to shit its proverbial pants when processing HostileImmigrationEvents because this check prevented tCharSpawnStats to get added to the Event. This _prerollRaiders check was deemed obsolete because this was the only place (left) in the code that mentioned this variable.
HLaan commented 2016-01-23 20:05:54 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in issue #16

mentioned in issue #16
HLaan commented 2016-01-24 14:24:15 +00:00 (Migrated from gitlab.com)
Copy link

I've played some more with this patch and I'm noticing that an high amount of raiders show up, compared to vanilla/pre-patch. On a save with a nearby warp portal, I noticed raiders jumping in every minute or so: situations with multiple breachers at the same time happened, also all the nearby ship hails appeared to be raiders, a pattern that re-emerged in a new save, far away from warpgates and with a low danger level (bottom right corner). Though based on mostly anecdotal evidence, this simple patch seemed to have great consequences in raider spawns, prompting for a balance change. Please test before merging. The crashes this patch addresses are solved though.

tl;dr Patch works, though probably caused balance regression.

I've played some more with this patch and I'm noticing that an high amount of raiders show up, compared to vanilla/pre-patch. On a save with a nearby warp portal, I noticed raiders jumping in every minute or so: situations with multiple breachers at the same time happened, also all the nearby ship hails appeared to be raiders, a pattern that re-emerged in a new save, far away from warpgates and with a low danger level (bottom right corner). Though based on mostly anecdotal evidence, this simple patch seemed to have great consequences in raider spawns, prompting for a balance change. Please test before merging. The crashes this patch addresses are solved though. tl;dr Patch works, though probably caused balance regression.
bryceharrington commented 2016-01-26 19:01:27 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 7bc9be6625

mentioned in commit 7bc9be6625e92bd1dce946921584b6c02d130634
bryceharrington commented 2016-01-26 19:01:28 +00:00 (Migrated from gitlab.com)
Copy link

Status changed to merged

Status changed to merged
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

   
Good First Issue

Good issue for understanding the codebase

  
High Priority Issue

   
Improvement

   
Proprietary

The issue is in or caused by proprietary artwork or data files that cannot be changed

No labels
Bug
Good First Issue
High Priority Issue
Improvement
Proprietary
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ald_productions/spacebase-v2-updated-code!56
No description provided.